Draft
Conversation
elezar
force-pushed
the
migrate-to-nvcdi-api
branch
2 times, most recently
from
52b9a64 to
f9c0907
Compare
elezar
commented
Oct 21, 2025
| // TODO: Instead of abusing CLI command we generate here, we should expose | ||
| // this API and use that instead. This would require refactoring in the | ||
| // toolkit. | ||
| cmd := devicenodes.NewCommand(log.StandardLogger()) |
elezar
force-pushed
the
migrate-to-nvcdi-api
branch
from
8154723 to
3feb86b
Compare
tariq1890
reviewed
Oct 21, 2025
cmd/nvidia-mig-manager/main.go
Outdated
| } | ||
|
|
||
| return rcfg.Run() | ||
| return rcfg.Run(ctx) |
Contributor
There was a problem hiding this comment.
we already ctx in the rcfg, err := reconfigure.New(ctx, clientset, migPartedBinary, opts) line. Can we access the context from the struct itself?
Member
Author
There was a problem hiding this comment.
Yes. You're right. I can use the context member.
elezar
force-pushed
the
migrate-to-nvcdi-api
branch
2 times, most recently
from
888a600 to
b29c4d2
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change switches from a direct invocation of the nvidia-ctk cdi generate command to using the nvcdi API. This matches what is done in the toolkit container to generate a CDI spec for management devices. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
migrate-to-nvcdi-api
branch
from
b29c4d2 to
f53a7f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally we would also switch away from using the nvidia-ctk CLI to create device nodes as part of this PR too.