Fix train.py for Adam optimizer betas type error#657
Open
mehmoodulhaq570 wants to merge 1 commit intoNVlabs:mainfrom
Open
Fix train.py for Adam optimizer betas type error#657mehmoodulhaq570 wants to merge 1 commit intoNVlabs:mainfrom
mehmoodulhaq570 wants to merge 1 commit intoNVlabs:mainfrom
Conversation
Author
|
This pull request fixes a runtime error encountered during training when initializing the Adam optimizer. The issue was caused by passing the betas parameter as a Python list ([0, 0.99]), whereas PyTorch’s torch.optim.Adam requires betas to be provided as a tuple of floats. |
|
I encountered the same Adam optimizer betas type error during training (CUDA 12.4, PyTorch 2.6.0). Converting betas to a tuple of floats resolves it. Suggestion: keeping the change stylistically consistent with the surrounding code (inline Example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Adam Optimizer Betas Type Error
Overview
This update fixes a runtime error encountered during training when initializing the Adam optimizer.
Problem
Training fails with the following error:
This happens because the
betasparameter is provided as a Python list instead of the required tuple format.Root Cause
PyTorch’s
torch.optim.Adamexpects thebetasargument in the following form:However, the existing configuration uses:
When the optimizer is created via:
this results in a runtime
ValueError.Fix
The optimizer configuration has been updated to pass
betasas a tuple:This fix has been applied to:
Impact
Testing