make walker.getOffset(-1) available in Sleigh as "operand_offset" #8542
+482
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue NationalSecurityAgency#4606, replacing (outdated) PR NationalSecurityAgency#4812. Issue NationalSecurityAgency#4606 is about supporting processors with PC-relative addressing, where addressing is based on the address of the operand instead of the opcode. See NationalSecurityAgency#4606 (comment) about Sleigh's inability to support this addressing mode. However, it turns out that Ghidra's varnode does track addresses of operands and which can be accessed via walker.getOffset(-1). This PR makes this value available in Sleigh as the predefined variable "operand_offset". Signed-off-by: Klaus Kämpf <[email protected]>
This is identical to the previous commit, but covering the Java implementation of Sleigh. Signed-off-by: Klaus Kämpf <[email protected]>
ryanmkurtz
added
Feature: Decompiler
Status: Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #4606, replacing (outdated) PR #4812.
Issue #4606 is about supporting processors with PC-relative addressing, where addressing is based on the address of the operand instead of the opcode.
See #4606 (comment) about Sleigh's inability to support this addressing mode.
However, it turns out that Ghidra's varnode does track addresses of operands and which can be accessed via walker.getOffset(-1). This PR makes this value available in Sleigh as the predefined variable "operand_offset".