Skip to content

make ObjectMappers consistent across GraphQLResponse and GraphQLClients #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make ObjectMappers consistent across GraphQLResponse and GraphQLClients #2159

wants to merge 1 commit into from

Conversation

regulskimichal
Copy link

@regulskimichal regulskimichal commented May 14, 2025 •
edited
Loading

Pull request checklist

  • Please read our contributor guide
  • Consider creating a discussion on the discussion forum
    first
  • Make sure the PR doesn't introduce backward compatibility issues
  • Make sure to have sufficient test cases

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

Currently there is an issue related to the recent changes that induced GraphQLRequestOptions and refactoring of createCustomObjectMapper() method, that makes it impossible to use custom ObjectMapper during deserialization of data in GraphQLResponse

Alternatives considered

Describe alternative implementation you have considered

@regulskimichal regulskimichal mentioned this pull request Jun 7, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbakker paulbakker Awaiting requested review from paulbakker paulbakker is a code owner

@kilink kilink Awaiting requested review from kilink kilink is a code owner

@srinivasankavitha srinivasankavitha Awaiting requested review from srinivasankavitha srinivasankavitha is a code owner

@iuliiasobolevska iuliiasobolevska Awaiting requested review from iuliiasobolevska iuliiasobolevska is a code owner

@kzwang kzwang Awaiting requested review from kzwang kzwang is a code owner

@asibross asibross Awaiting requested review from asibross asibross is a code owner

@iparadiso iparadiso Awaiting requested review from iparadiso iparadiso is a code owner

@jjacobs44 jjacobs44 Awaiting requested review from jjacobs44 jjacobs44 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@regulskimichal