chore: if the bool field is null set the inlined boolean as null #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoramirez
force-pushed
the
prim-null
branch
from
e4b2176 to
fc38d13
Compare
|
i addressed the existing usage that this change would have broken. i will land this next week. |
eduardoramirez
force-pushed
the
prim-null
branch
from
fc38d13 to
92f7302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for hollow inline, we want to keep the concept of null like we do for the other ones. it's not 100% backwards compatible, but since this is only used within RH we can see how safe it is based on usage. ideally, we patch this before broader usage appears