sort stringified set elements with one field #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvoli
force-pushed
the
250616.add-stringify-set-sort
branch
from
58b926c to
1161356
Compare
kvoli
changed the title
kvoli
force-pushed
the
250616.add-stringify-set-sort
branch
from
1161356 to
ec9e86d
Compare
Previously, parsing post data from the request URI query string would decode sequences twice, first in `getQuery()`, then in `parseQueryString`. This would cause `'+'` characters to be converted to whitespace. Fix this by using `getRawQuery()` instead.
kvoli
force-pushed
the
250616.add-stringify-set-sort
branch
3 times, most recently
from
66daf5e to
c41e71c
Compare
kvoli
changed the title
kvoli
changed the title
kvoli
force-pushed
the
250616.add-stringify-set-sort
branch
from
c41e71c to
9ee9930
Compare
kvoli
changed the title
kvoli
force-pushed
the
250616.add-stringify-set-sort
branch
3 times, most recently
from
dfc95fd to
06f5f78
Compare
kvoli
force-pushed
the
250616.add-stringify-set-sort
branch
2 times, most recently
from
362d581 to
da7b901
Compare
Sunjeet
reviewed
Jun 19, 2025
hollow/src/main/java/com/netflix/hollow/tools/stringifier/HollowRecordJsonStringifier.java
Show resolved
Hide resolved
Sunjeet
reviewed
Jun 19, 2025
hollow/src/main/java/com/netflix/hollow/tools/stringifier/HollowRecordStringifier.java
Show resolved
Hide resolved
Sunjeet
reviewed
Jun 19, 2025
hollow/src/test/java/com/netflix/hollow/core/write/objectmapper/HollowObjectMapperTest.java
Outdated
Show resolved
Hide resolved
Stringified set elements are now outputted in sorted order when each element has exactly one field. Previously the output order was determined by the element ordinals. This change only affects the Hollow Explorer UI.
kvoli
force-pushed
the
250616.add-stringify-set-sort
branch
from
da7b901 to
635ca33
Compare
|
TYFTR! Updated with backwards compatibility constructor changes @Sunjeet. |
Sunjeet
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stringified set elements are now outputted in sorted order when each
element has exactly one field. Previously the output order was
determined by the element ordinals.
This change only affects the Hollow Explorer UI.