Detect chunked transfer-encoding as last value #1996
+98
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Whilst
Transfer-Encoding: chunked
is commonplace, RFC 7230 does permit comma separated values, in whichchunked
should be the last value.This has influence on early body detection,
zuul/zuul-core/src/main/java/com/netflix/zuul/netty/server/ClientRequestReceiver.java
Lines 379 to 381 in 2232215
Filters implementing
shouldFilter
relying onrequest.hasBody()
evaluating to true may be skipped when subsequent HTTP content arrives after initial header processing in the pipeline.More broadly, is the presence of the "Transfer-Encoding" header sufficient to call
request.setHasBody(true)
, rather than explicitly checking forchunked
?I initially filed this issue through HackerOne (report id 3333247) as custom security filters dependent on the body may be bypassed, but it was triaged as informative and closed by HackerOne.