Don't start the timeout if the connection was already closed #2011
+82
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguerra
requested review from
AlexanderEllis,
argha-c,
gavinbunney,
lalernehl and
lindseyreynolds
as code owners
emmaworley
approved these changes
Oct 7, 2025
gavinbunney
approved these changes
Oct 7, 2025
lalernehl
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some race situations where
startReadTimeoutHandleris called after the channel has been closed/deregistered. This results in the addBefore call failing because DefaultOriginChannelInitializer.ORIGIN_NETTY_LOGGER is not in the pipeline anymore. I added a simple guard to short circuit when the channel is already closed