feat: add workflow to test buf difs #3212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| with: | ||
| go-version-file: go.mod | ||
| - name: Set up buf | ||
| uses: bufbuild/buf-setup-action@v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium generated
rodrigo-pino
temporarily deployed
to
Development
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
==========================================
- Coverage 76.12% 76.08% -0.05%
==========================================
Files 310 310
Lines 29687 29687
==========================================
- Hits 22600 22588 -12
- Misses 5450 5456 +6
- Partials 1637 1643 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
infrmtcs
reviewed
Oct 27, 2025
Comment on lines
+12
to
+14
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true |
Contributor
There was a problem hiding this comment.
We probably don't need this.
infrmtcs
reviewed
Oct 27, 2025
| make generate-buf | ||
| - name: Check for uncommitted changes | ||
| run: | | ||
| if ! git diff --exit-code; then |
Contributor
There was a problem hiding this comment.
I think writing a new uncommitted file won't fail this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I have an error somewhere because it should've failed either at the first or second commit error.
I think we can add a check for
go generatecode as well 🤔