Move from setup.py to pyproject.toml #1180
Conversation
apdavison
left a comment
apdavison
left a comment
There was a problem hiding this comment.
This looks good. I think doc/source/conf.py will need to be updated to get the version string from the metadata file.
|
|
||
| description = "Neo is a package for representing electrophysiology data in Python, together with support for reading a wide range of neurophysiology file formats" | ||
|
|
||
| readme = "README.rst" |
There was a problem hiding this comment.
I presume this replaces the "long_description" field?
There was a problem hiding this comment.
description is the short one from what I understand.
For the long one. I don't known how to include yet.
I forgot also about that.
Maybe the readme replace it no ?
There was a problem hiding this comment.
This readme is also the readme in pypi. So yes this replace the long description.
Oups. I also forgot that. |
|
@apdavison : other question. Or do we switch to ?
I will no modify NOT the doc because you are working inanother PR on it but maybe you could propagate this also no ? |
pyproject.toml
Outdated
| maxwell = ['h5py'] | ||
| biocam = ['h5py'] | ||
|
|
||
| # TODO [all] |
There was a problem hiding this comment.
@JuliaSprenger please note that I have not find a way to do the all the moment.
There was a problem hiding this comment.
I think for implementing the 'all' keyword in this framework we need to duplicate the requirements here. It's not nice, but acceptable I think.
* master: (51 commits) Make rescale signature compatible with quantities 0.14.0 Return to fail-fast: true remove combination of Python/NumPy which doesn't build on Github Actions Add Python 3.11 to test matrix fix deprecation warnings with NumPy 1.24 update docs update test matrix following NEP29 + 1 year fix typo in "ebrains mirror" workflow Create ebrains.yml Update neo/test/iotest/common_io_test.py enable closing of dangling file ios move mutable class attributes to avoid stacking modifications across instances refactor klustakwik to use pathlib instead of os.path remove outdated imports update neuroshare tests to also work for neuroshareapiio update klustakwik tests to be reincluded in test runs make neurosharectypesio.py pathlib robust make neurosharectypesio.py pathlib robust harmonize parameters across neuroshareios Performance optimization: check test files once per TestClass and not once per test case ... # Conflicts: # .github/workflows/core-test.yml # requirements.txt # setup.py
apdavison
changed the title
3 participants
Hi @apdavison @JuliaSprenger
I think the new trend is to move from dynamic setup (setup.py) to static declaration (pyproject.toml).
There somes peps about this and I think it help many tools for building and packaging.
Here a first draft for this.
Normally everything is centralize in pyproject.toml.
It still use setuptools for building but the medata come from pyproject.toml.
If you have time to make feeback on this. It would be cool.
EDIT:
versions.