Skip to content

Conversation

@JuliaSprenger
Copy link
Member

@JuliaSprenger JuliaSprenger commented Nov 3, 2022

By fetching the test data only once per test class and on once per test case the test time reduces drastically. This reduces the iotest time from 13 minutes to less than 4 minutes.

@JuliaSprenger JuliaSprenger added this to the 0.12.0 milestone Nov 4, 2022
@JuliaSprenger
Copy link
Member Author

@samuelgarcia @apdavison What do you think?

@JuliaSprenger JuliaSprenger marked this pull request as ready for review November 4, 2022 10:56
@samuelgarcia samuelgarcia self-assigned this Nov 25, 2022
@samuelgarcia
Copy link
Contributor

Hi Julia,
I was not ware of this setUpClass!!
This is super cool.
Thanks.
It is OK for me.
Can I merge this ?

@JuliaSprenger
Copy link
Member Author

@samuelgarcia Yes, go ahead!

@samuelgarcia samuelgarcia merged commit 8428d44 into NeuralEnsemble:master Nov 25, 2022
@JuliaSprenger JuliaSprenger deleted the enh/ci_performance branch November 25, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants