Open
Conversation
satyam73
suggested changes
Jan 24, 2025
| if (error instanceof Error) { | ||
| res.status(500).json({ error: error.message }); | ||
| } else { | ||
| res.status(500).json({ error: 'An unknown error occurred' }); |
Contributor
There was a problem hiding this comment.
'An unknown error occurred' lets define a standard constant and use it here?
Comment on lines
+4
to
+16
| export const checkProjectAccess = async ( | ||
| project_id: string, | ||
| user_id: string, | ||
| ): Promise<boolean> => { | ||
| const prisma = new PrismaClient(); | ||
| const project = await prisma.project.findFirst({ | ||
| where: { | ||
| id: project_id, | ||
| created_by: user_id, | ||
| }, | ||
| }); | ||
| return project !== null; | ||
| }; |
Contributor
There was a problem hiding this comment.
this can be split into two one model function and one middleware function the checking part middleware will do and model function will be only responsible for fetching the data
Comment on lines
+22
to
+28
| id: project.id, | ||
| name: project.name, | ||
| description: project.description, | ||
| logo: project.logo, | ||
| created_by: project.created_by, | ||
| created_at: project.created_at.toISOString(), | ||
| updated_at: project.updated_at.toISOString(), |
Contributor
There was a problem hiding this comment.
I think we can write utils fo transforming this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.