FromCabal.PostProcess: ignore missing old binding in replace #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bindings generated by hackage2nix and cabal2nix differ since the former may actually look at pkgs to figure out system dependencies. As a result some after the fact adjustments done for the benefit of hackage2nix may not be applicable to cabal2nix-generated expressions. In particular, cabal2nix will never generate a nullBinding for a system dependency that has not been successfully resolved in nixpkgs. The added golden test cases would previously trigger this issue.
cdepillabout
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bindings generated by hackage2nix and cabal2nix differ since the former may actually look at pkgs to figure out system dependencies. As a result some after the fact adjustments done for the benefit of hackage2nix may not be applicable to cabal2nix-generated expressions. In particular, cabal2nix will never generate a nullBinding for a system dependency that has not been successfully resolved in nixpkgs.
The added golden test cases would previously trigger this issue.
Resolves the issue described in #649.