Language.Nix.Identifier: idents with non ASCII chars need quoting #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternenseemann
force-pushed
the
language-nix-non-ascii
branch
from
c00b830 to
87cc11c
Compare
We more or less assume an UTF-8 encoding so ASCII codepoints would be mapped to bytes decodable as ASCII since Nix itself uses byte strings. Add a test for this and a random assortment of random trivial to check properties for needsQuoting.
sternenseemann
force-pushed
the
language-nix-non-ascii
branch
from
87cc11c to
3f03407
Compare
wolfgangwalther
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We more or less assume an UTF-8 encoding so ASCII codepoints would be mapped to bytes decodable as ASCII since Nix itself uses byte strings.
Add a test for this and a random assortment of random trivial to check properties for needsQuoting.