Make self attrs overridable #13831
Open
Make self attrs overridable #13831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
fetching
kip93
force-pushed
the
fix/self-override
branch
from
7952ad0 to
9c0b362
Compare
kip93
force-pushed
the
fix/self-override
branch
from
9c0b362 to
4306a55
Compare
kip93
force-pushed
the
fix/self-override
branch
from
4306a55 to
52bda95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The self attributes should (I believe) be used as defaults, but currently setting a self attribute makes it silently ignore any explicit values passed by consumers.
Context
Noticed this while working on #13743, but decided to move it to its own PR to avoid adding noise there. Have not created an issue for it though, and cannot find any relevant issues to link against.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.