FFI for DerivationBuilder
#13903
Draft
FFI for DerivationBuilder
#13903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 3, 2025
Mic92
reviewed
Sep 3, 2025
Mic92
reviewed
Sep 3, 2025
src/libstore-c/nix_api_store.h
Outdated
|
|
||
| StorePath * nix_derivation_calc_path(nix_c_context * context, Store * store, Derivation * derivation); | ||
|
|
||
| StorePath * nix_add_derivation(nix_c_context * context, Store * store, Derivation * derivation); |
Mic92
reviewed
Sep 3, 2025
Mic92
reviewed
Sep 3, 2025
Ericson2314
force-pushed
the
derivation-builder-ffi
branch
3 times, most recently
from
d31c3bd to
304cc0d
Compare
|
Not really in favor of this. Contrary to the store/eval APIs, this is extremely Nix-internal, so we would be committing to having to maintain a stable API for something that has never been stable. |
Ericson2314
force-pushed
the
derivation-builder-ffi
branch
from
304cc0d to
3006124
Compare
It really doesn't belong in `DerivationBuilder`, so long as all derivaiton builders are local. It belongs with the logic that decides hook vs no hook. Also, it was the only thing throwing `BuildError` from `startBuilder`, so we can now remove the `try...catch` around that.
…possible This is for FFI: we can make a `StoreDirConfig` with FFI, but we can't realistically make a `Store` that way.
The hope is make `DerivationBuilder` eaiser to use with much less of libnixstore.
Ericson2314
force-pushed
the
derivation-builder-ffi
branch
from
3006124 to
74d2354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Depends on #13865
Depends on #13907
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.