JSON impls without store dir #13942
Draft
JSON impls without store dir #13942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
json-no-store-dir
branch
2 times, most recently
from
3208245 to
2704e1a
Compare
|
I discussed this with @edolstra a bit at the meeting
|
Ericson2314
force-pushed
the
json-no-store-dir
branch
from
2704e1a to
8b413c1
Compare
github-actions
bot
added
new-cli
Ericson2314
force-pushed
the
json-no-store-dir
branch
from
8b413c1 to
05a4cf9
Compare
github-actions
bot
added
the
with-tests
Ericson2314
force-pushed
the
json-no-store-dir
branch
from
05a4cf9 to
1d1b475
Compare
Ericson2314
added a commit
that referenced
this pull request
Sep 13, 2025
Misc prep changes for #13942
See #13570 for details --- the idea is that included the store dir in store paths makes systematic JSON parting with e.g. Serde, Aeson, nlohmann, or similiar harder. After talking to Eelco, we are changing the `Derivation` format right away because not only is `nix derivation` technically experimental, we think it is also less widely used in practice than, say, `nix path-info`. Progress on #13570
This is more flexible, and needed for me to be able to reshuffle the inheritance bureaucracy to make the JSON instances more precise.
Progress on #13570. If we depend on the store dir, our JSON serializers/deserializers take extra arguements, and that interfaces with the likes of various frameworks for associating these with types (e.g. nlohmann in C++, Serde in Rust, and Aeson in Haskell).
If we depend on the store dir, our JSON serializers/deserializers take extra arguements, and that interfaces with the likes of various frameworks for associating these with types (e.g. nlohmann in C++, Serde in Rust, and Aeson in Haskell).
Ericson2314
force-pushed
the
json-no-store-dir
branch
from
1d1b475 to
fdf7dfd
Compare
|
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
So far this is just declarations
If we depend on the store dir, our JSON serializers/deserializers take extra arguements, and that interfaces with the likes of various frameworks for associating these with types (e.g. nlohmann in C++, Serde in Rust, and Aeson in Haskell).
Context
Fix #13570
Depends on #13980
I talked to @edolstra about this at NixCon, briefly.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.