Skip to content

Conversation

@wighawag
Copy link
Contributor

@wighawag wighawag commented Nov 8, 2025

This PR fix issues with some network that do not follow the spec and do not add an extra value in the response of eth_feeHistory for the baseFeePerGas array

Somnia Testnet for example

It does not change the behavior for other

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2025

🦋 Changeset detected

Latest commit: 806ee5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fvictorio
Copy link
Member

Hey Ronan, thanks for this. I guess it makes sense. Technically the maxFeePerGas value for these networks will be computed differently. A better fix would be to actually compute the proper base fee for the next block ourselves. But I don't think it makes sense to do that just for some edge cases.

This PR has a couple of unrelated commits though. Could you rebase it so that there's only one commit with this change?

@wighawag wighawag force-pushed the fix/network-without-extra-baseFeePerGas-value branch from 1f00da4 to 3286bed Compare November 10, 2025 15:37
@wighawag
Copy link
Contributor Author

just did it, thanks!

@fvictorio fvictorio added the no docs needed This PR doesn't require links to documentation label Nov 17, 2025
@fvictorio fvictorio added this pull request to the merge queue Nov 17, 2025
@fvictorio
Copy link
Member

Thanks!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 17, 2025
@fvictorio fvictorio added this pull request to the merge queue Nov 17, 2025
Merged via the queue into NomicFoundation:main with commit c653045 Nov 17, 2025
202 of 203 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no docs needed This PR doesn't require links to documentation status:triaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants