Enhance GitHub Actions for releasing shared #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the GitHub Actions workflows for releasing the shared package by improving messaging, clarifying workflow purposes, and refining the release process. The changes focus on better user experience through clearer naming conventions and more informative output messages.
- Updated workflow names and comments to clarify their purposes and distinguish between automatic and manual releases
- Enhanced error and status messages with emojis and clearer descriptions for better visibility in GitHub Actions UI
- Improved output formatting with step summaries and npm package links for better release tracking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/release-shared.yml |
Updated workflow name, improved error messaging, renamed steps for clarity, and added npm release summary with package link |
.github/workflows/npm-publish-switch.yml |
Added dynamic run names, updated job names from "publish" to "release", and refined comments for better clarity |
.github/workflows/auto-publish-shared.yml |
Changed workflow name and improved messaging for non-release scenarios with more descriptive explanations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There were two workflows named "Release shared": `release-shared.yml` and `npm-publish-switch.yml`. This made it confusing at https://github.com/NordicSemiconductor/pc-nrfconnect-launcher/actions in the left sidebar.
We sometimes use "publish" and sometimes "release" to refer to the same action of releasing a new version of shared. This is now more consistent. We still use "publish" in some workflow file names because renaming those is a pain.
datenreisender
force-pushed
the
push-rpkxtsrkvzky
branch
from
3607018 to
7fa979e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.