tests: decode: corner_cases: Add more compiler warnings and fix #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
force-pushed
the
compiler-warnings
branch
from
ce547ef to
6e134be
Compare
float-conversion warning on a default value. Refactor value suffix code to be based on the variable type instead of the literal value. Also add more robust checking for int and float that accepts all values (isdigit e.g. doesn't accept negative values) -Wfloat-comparison was left out because the comparisons are needed for floatXY_expect() The if statement in the CMakeLists.txt was out of date. MINIMAL_LIBC is no longer default, and zcbor now uses printf directly instead of printk. Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
compiler-warnings
branch
from
6e134be to
c886502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
float-conversion warning on a default value.
-Wfloat-comparison was left out because the comparisons are needed for floatXY_expect()