-
-
Notifications
You must be signed in to change notification settings - Fork 862
[19.0][MIG] bi_sql_editor: Migration to 19.0 #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
…ield; [ADD] security
…fresh date time on the action name of each sql materialized view
Fix error '... is not a table or foreign table' Fix view (colors + oe_highlight) Fix tests Fix README + manifest Fix back to draft Fix cron call + default values Use Postgres version 9.6 for travis builds
* [IMP] is_materialized field non readonly on sql_valid state ; [FIX] block possibility to set indexes on non materialized view * [FIX] set domain_force, group_ids readonly if state > sql_valid * [IMP] better display of the field group_ids * [IMP] possibility to reorder menu items from sql views * [IMP] Do not warn user when setting sql view to draft if state is sql_valid * [REF] * [FIX] Set Date of the first execution in the action name
[UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
bi_sql_editor 12.0.1.1.0 [UPD] README.rst [UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/
Currently translated at 29.1% (32 of 110 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-18.0/reporting-engine-18.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-bi_sql_editor/
Currently translated at 100.0% (146 of 146 strings) Translation: reporting-engine-18.0/reporting-engine-18.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-bi_sql_editor/it/
Use timezone-aware datetime methods to resolve deprecation warnings. Signed-off-by: Emmanuel Ferdman <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-18.0/reporting-engine-18.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-bi_sql_editor/
Currently translated at 66.8% (97 of 145 strings) Translation: reporting-engine-18.0/reporting-engine-18.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-bi_sql_editor/ca/
Currently translated at 93.7% (136 of 145 strings) Translation: reporting-engine-18.0/reporting-engine-18.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-bi_sql_editor/ca/
Currently translated at 100.0% (145 of 145 strings) Translation: reporting-engine-18.0/reporting-engine-18.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-bi_sql_editor/ca/
2380b1a to
4927854
Compare
bi_sql_editor/models/bi_sql_view.py
Outdated
| from psycopg2.sql import SQL, Identifier | ||
|
|
||
| from odoo import SUPERUSER_ID, _, api, fields, models | ||
| from odoo import SUPERUSER_ID, api, fields, models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0
When using SUPERUSER_ID variable, import it from api instead inside odoo itself. More info at odoo/odoo@d6a955f10483.
Either from odoo.api import SUPERUSER_ID or use api.SUPERUSER_ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
| <odoo> | ||
| <record id="base.group_no_one" model="res.groups"> | ||
| <field name="users" eval="[(4, ref('base.user_admin'))]" /> | ||
| <field name="user_ids" eval="[(4, ref('base.user_admin'))]" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<field name="user_ids" eval="[Command.link(ref('base.user_admin'))]" />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the commit “[MIG] bi_sql_editor: Migration to 19.0”? It's like that.
Except for the command, which I don't think is necessary.
| "name": "Demo User", | ||
| "login": "demo_bi_sql", | ||
| "email": "[email protected]", | ||
| "group_ids": [(6, 0, [cls.group_bi_no_access.id])], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"group_ids": [Command.set(cls.group_bi_no_access.ids)],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary
| def _get_user(cls, access_level=False): | ||
| if access_level == "manager": | ||
| cls.demo_user.write({"groups_id": [(6, 0, cls.group_bi_manager.ids)]}) | ||
| cls.demo_user.write({"group_ids": [(6, 0, cls.group_bi_manager.ids)]}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the commit “[MIG] bi_sql_editor: Migration to 19.0”? It's like that.
yankinmax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of suggestions
4927854 to
3144fdc
Compare
Depends on: