[17.0][FWD] endpoint: forward-port querystring params usage
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @simahawk, |
Contributor
Author
|
NB: tests are failing for reasons unrelated to these commits |
SilvioC2C
added a commit
to camptocamp/edi-framework
that referenced
this pull request
Sep 22, 2025
Compatibility w/ OCA/web-api#114
ivantodorovich
approved these changes
Sep 25, 2025
jcoux
approved these changes
Sep 29, 2025
dreispt
approved these changes
Oct 19, 2025
simahawk
requested changes
Dec 9, 2025
Contributor
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
can we have a test update?
| handler = self_with_user._get_handler() | ||
| try: | ||
| res = handler(request) | ||
| # In case the handler does not support params |
Contributor
There was a problem hiding this comment.
I would simply let it fail. Or if you really want you can catch a TypeError and log it. But I would just let it break. Beside, I doubt anyone did ever implement a different handler :)
Contributor
Author
|
@simahawk would it be better to make a commit in the v14 PR and port it here, or would suggest a commit here for simplicity? |
Contributor
|
we can backport it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of #80
Also includes renaming usages of
paramstoquerystring_params