unittests: convert stream-tcp-reassemble to FAIL/PASS API

[kaddujames501-ship-it]

Issue #6324
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

• I have read the contributing guide lines at
  https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html

Our Contribution agreements:

• I have signed the Open Information Security Foundation contribution agreement at
  https://suricata.io/about/contribution-agreement/ (note: this is only required once)

Changes (if applicable):

• I have fixed a ticket at
  https://redmine.openinfosecfoundation.org/projects/suricata/issues/6324

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6324

Describe changes:

• Convert unittests to new FAIL/PASS API - stream-tcp-reassemble.c file

Provide values to any of the below to override the defaults.

• To use a Suricata-Verify or Suricata-Update pull request,
  link to the pull request in the respective _BRANCH variable.
• Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=

James Kaddu: [email protected]

[victorjulien]

Git message is still not compliant to our docs. Please review them as well as have a look at recent existing commits in the repo.

[kaddujames501-ship-it]

Thanks a lot @victorjulien for the review. Lemme adjust ASAP.

[jufajardini]

As per Victor's comment, please.

[kaddujames501-ship-it]

As per Victor's comment, please.

Which works better, ammending or opening another PR with the required commit message

[kaddujames501-ship-it]

Git message is still not compliant to our docs. Please review them as well as have a look at recent existing commits in the repo.

Hello, I ammended the Git Message.

[github-actions]

NOTE: This PR may contain new authors.

[jufajardini]

Git message is still not compliant to our docs. Please review them as well as have a look at recent existing commits in the repo.

Hello, I ammended the Git Message.

Thanks, I'm running the CI checks now.
Please notice that in our normal workflow process for PRs, we always prefer that feedback go into a follow-up PR.

[kaddujames501-ship-it]

Hello @jufajardini, @victorjulien should I open another PR fixing the current CI failures and close this ?

[kaddujames501-ship-it]

Closing this PR to consolidate all changes into a single commit, as per
Suricata commit guidelines. A new PR will be opened with a single,
properly formatted commit (#14134).