Skip to content

Conversation

@liheng562653799
Copy link
Contributor

@liheng562653799 liheng562653799 commented Oct 21, 2025

Ticket: 8003

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/8003

Describe changes:

  • In parser.rs, when is_token_char and is_alphanumeric are called together, is_alphanumeric is deleted.
  • Four lines are modified.

Provide values to any of the below to override the defaults.

  • To use a Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=

@github-actions
Copy link

NOTE: This PR may contain new authors.

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.46%. Comparing base (0990c9d) to head (202fa6a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14096      +/-   ##
==========================================
- Coverage   84.46%   84.46%   -0.01%     
==========================================
  Files        1013     1013              
  Lines      271932   271932              
==========================================
- Hits       229694   229693       -1     
- Misses      42238    42239       +1     
Flag Coverage Δ
fuzzcorpus 63.41% <100.00%> (+<0.01%) ⬆️
livemode 19.42% <0.00%> (+<0.01%) ⬆️
pcap 44.85% <100.00%> (+0.01%) ⬆️
suricata-verify 65.27% <100.00%> (-0.01%) ⬇️
unittests 59.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liheng562653799
Copy link
Contributor Author

liheng562653799 commented Oct 22, 2025

What should I do next, I can't do re-run and I can't find where the problem is.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm being too strict, but I would prefer if the commit message had a simple explanation of where the redundancy is.

liheng562653799 and others added 5 commits October 23, 2025 10:31
Delete call of is_alphanumeric where is_alphanumeric and is_token_char are called together.
Four places are modified.

Ticket: 8003
Add missing flow memset in test SCSigOrderingTest12 to avoid the crash.

Test SCSigOrderingTest12                                          : Info: unittest-helper: Sid 1 matched 1 times, as expected [UTHCheckPacketMatchResults:util-unittest-helper.c:638]
Info: unittest-helper: Sid 2 matched 1 times, as expected [UTHCheckPacketMatchResults:util-unittest-helper.c:638]
bash: line 144: 88567 Segmentation fault      (core dumped) ./src/suricata -u -l /tmp/

Bug: OISF#8008.
@liheng562653799
Copy link
Contributor Author

Maybe I'm being too strict, but I would prefer if the commit message had a simple explanation of where the redundancy is.

It's goot having clear annotations, I have add some explanation.

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution to Suricata! Please address Juliana's comments, clean the git history and submit a new PR as per our contribution guidelines linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants