-
Notifications
You must be signed in to change notification settings - Fork 1.6k
rust/sip: delete redundant computing codes #14096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ticket: 8003
|
NOTE: This PR may contain new authors. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14096 +/- ##
==========================================
- Coverage 84.46% 84.46% -0.01%
==========================================
Files 1013 1013
Lines 271932 271932
==========================================
- Hits 229694 229693 -1
- Misses 42238 42239 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
What should I do next, I can't do re-run and I can't find where the problem is. |
jufajardini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm being too strict, but I would prefer if the commit message had a simple explanation of where the redundancy is.
Delete call of is_alphanumeric where is_alphanumeric and is_token_char are called together. Four places are modified. Ticket: 8003
Add missing flow memset in test SCSigOrderingTest12 to avoid the crash. Test SCSigOrderingTest12 : Info: unittest-helper: Sid 1 matched 1 times, as expected [UTHCheckPacketMatchResults:util-unittest-helper.c:638] Info: unittest-helper: Sid 2 matched 1 times, as expected [UTHCheckPacketMatchResults:util-unittest-helper.c:638] bash: line 144: 88567 Segmentation fault (core dumped) ./src/suricata -u -l /tmp/ Bug: OISF#8008.
…icata into sip-redudant
It's goot having clear annotations, I have add some explanation. |
inashivb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution to Suricata! Please address Juliana's comments, clean the git history and submit a new PR as per our contribution guidelines linked above.
Ticket: 8003
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8003
Describe changes:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=