Feature: Implement WRITE support in nfs2 Task: #4946

[kaddujames501-ship-it]

Issue #4946
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

• I have read the contributing guide lines at
  https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html

Our Contribution agreements:

• I have signed the Open Information Security Foundation contribution agreement at
  https://suricata.io/about/contribution-agreement/ (note: this is only required once)

Changes (if applicable):

• I have fixed a ticket at
  https://redmine.openinfosecfoundation.org/projects/suricata/issues

Link to ticket: https://redmine.openinfosecfoundation.org/issues/4946

Describe changes:

• Convert unittests to new FAIL/PASS API - stream-tcp-reassemble.c file

Provide values to any of the below to override the defaults.

• To use a Suricata-Verify or Suricata-Update pull request,
  link to the pull request in the respective _BRANCH variable.
• Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=

James Kaddu: [email protected]

[github-actions]

NOTE: This PR may contain new authors.

[codecov]

Codecov Report

❌ Patch coverage is 68.49315% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.46%. Comparing base (0990c9d) to head (72bc0b9).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14111      +/-   ##
==========================================
- Coverage   84.46%   84.46%   -0.01%     
==========================================
  Files        1013     1013              
  Lines      271932   271958      +26     
==========================================
+ Hits       229694   229708      +14     
- Misses      42238    42250      +12     

Flag	Coverage Δ
fuzzcorpus	63.41% <55.76%> (-0.01%)	⬇️
livemode	19.37% <0.00%> (-0.04%)	⬇️
pcap	44.86% <9.61%> (+0.02%)	⬆️
suricata-verify	65.24% <10.00%> (-0.04%)	⬇️
unittests	59.46% <53.52%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[victorjulien]

Commit message should meet our requirements, can you update it?

What pcap did you test with? I didn't see one in the ticket and there is no Suricata-Verify test.

[jufajardini]

To Victor's point, could you please create Suricata-verify tests to accompany this work?

Thanks in advance :)

[jufajardini]

Why this extra line here?

[kaddujames501-ship-it]

oooh, that was a typo. will work on that.

[kaddujames501-ship-it]

Commit message should meet our requirements, can you update it?

What pcap did you test with? I didn't see one in the ticket and there is no Suricata-Verify test.

thanks for the review, lemme work on the suggested changes.

[victorjulien]

Can you answer the question about the pcap/SV test?

[victorjulien]

Git message needs to meet our guidelines

[kaddujames501-ship-it]

Can you answer the question about the pcap/SV test?
Sure, Victor, I am pushing a PR to SV. Was doing final touches. How do we format SV changes

[kaddujames501-ship-it]

Git message needs to meet our guidelines

hello Victor, this PR here is a follow-up of the requested changes.

[inashivb]

Replaced w #14171

Hey @kaddujames501-ship-it ! Please close any old PRs once you have created a new one w feedback incorporated. Thank you! :)