Skip to content

fix: improve wording of base-filter help dialog #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ca-d merged 1 commit into from
Mar 28, 2025
Merged

fix: improve wording of base-filter help dialog #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions default-help-base-dialog-content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
export const DefaultHelpBaseDialogContent = `
<h3>Base Comparison Rules Help</h3>

<p>The one of the two groups of filters shown below will applied to <strong>each</strong> set
of comparison rules. If a rule is set to "exclusive" mode (default), then the corresponding rule
set from the "Exclude Rules" section will be applied. If a rule is set to "inclusive" mode, then
the corresponding rule set from the "Include Rules" section will be applied.
</p>
<p>Any changes made header will be applied to all rules. Use the "Reset" button in the footer to discard all saved changes and revert to the the defaults</p>
<p>Base rules apply to all rules.</p>

<p>One of the two groups of filters shown below will applied to each set of comparison rules on dependent rules. If a rule is set to "exclusive" mode (default), then the corresponding rule set from the "Exclude Rules" section will be applied. If a rule is set to "inclusive" mode, then the corresponding rule set from the "Include Rules" section will be applied.</p>

<p>The default settings are to ensure that naming identifiers don't prevent comparisons between objects (e.g. IEDs with a different name for example).
Use the "Reset" button in the footer to discard all saved changes and revert to the the defaults.</p>

`;
1 change: 1 addition & 0 deletions info-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,6 @@ export class InfoDialog extends LitElement {

a {
color: var(--oscd-base02);
}
`;
}