Closed
Conversation
Only works when kernel is a Loopy kernel.
…he tree vectorisation flag for our vectorisation anyways.
Don't vectorise, if complex arguments. Check if vect strategy specified, otw dont vectorise.
connorjward
reviewed
Mar 1, 2022
Collaborator
connorjward
left a comment
There was a problem hiding this comment.
I think there are going to be a few naming errors from my refactoring. I've labelled where they are.
…ross caller-callee is a bit involved and loopy can't deal with it yet.
connorjward
reviewed
May 25, 2022
Collaborator
connorjward
left a comment
There was a problem hiding this comment.
Only one comment. Otherwise looks good AFAICT. You should definitely run the Firedrake test suite to make sure you haven't broken anything by accident.
N.B. This is currently set to use PYOP2_TIME as the configuration option. This is misleading and should be changed.
Connorjward/add nbytes
Don't add py-cpuinfo
Loopy now requires py3.8
Closed
Collaborator
|
Closing as #677 is a newer version of the same things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements automatic cross-element vectorisation (This is the work from TJ and Kaushik)
See firedrakeproject/firedrake#2365 for
firedrakeCI runs.The corresponding loopy PR is inducer/loopy#557.
Big thanks to @kaushikcfd for working hard on an update of this so that we can get it merged.
The mechanism in PyOP2
CVectorExtensionsTargetlp.VectorizeTag(lp.OpenMPSIMDTag())whereVectorizeTagindicates that we try to use vector extensions first, but if an instruction can't be vectorised we use the fallbackOpenMPSIMDTagwhich wraps the instruction in openmp simd pragmasKernels which cannot be vectorised
Single instructions which cannot be vectorised