Conversation
|
Jenkins for all regression tests should fail as we added another output vector. |
blattms
added
the
manual:new-feature
|
jenkins build this please |
|
OK. seems like SMSPEC file is not tested. |
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
This is a good start. I'd appreciate some additional refactoring before merging though.
blattms
left a comment
blattms
left a comment
There was a problem hiding this comment.
comments have been addressed.
|
jenkins build this please |
The part that constructs the |
blattms
force-pushed
the
feature/support-runtimei
branch
from
d937781 to
221184f
Compare
|
jenkins build this please |
|
jenkins build this please |
blattms
force-pushed
the
feature/support-runtimei
branch
3 times, most recently
from
b6a0f9b to
368eec9
Compare
blattms
force-pushed
the
feature/support-runtimei
branch
from
368eec9 to
23b0b41
Compare
|
jenkins build this opm-simulators=6894 please |
|
This is based on #5038 now to get a correct value for Item 1 if the simulation is stopped in an ACTIONX |
The final write is special as it might create an RSM file. Up to now we created this file only for the last write of the last report step of a simulation. This approach neglected that a simulation might finish before the last step if it encounters an EXIT keyword inside of an executed ACTIONX statement. With this change we will also write an RSM file in this case. Such a file was missing before.
This is needed by some external tools.
RUNTIMEI is an integer vector of size 50 and we store the following
- item 1: 2 if simulation is finshed, 1 otherwise
- item 3: The index of the first report step of the
simulation (zero-based)
- item 4: The index of the current report step of the
simulation (zero-based)
- item 5-9: When the simulation was started (YYYY, MM, DD, HH, MM,
SS). Note that this a rough approximation as we use the time that
initialize output.
- item 10-14: The simulation time when the last report step was
written (YYYY, MM, DD, HH, MM, SS)
- item 35: The value used for BASIC of RPTRST or 0 if that was omitted.
All other items are zero.
Before we would have written the file only after the first time step of the last report step. Hence simulations that did adaptive time stepping would stay marked as not finished for upcoming RUNTIMEI support. Previously, if output writing of arrays WGNAMES and KEYWORDS changed due to e.g. ACTIONX in one of the adaptive time steps that was also not reflected in the in the SMSPEC file.
blattms
force-pushed
the
feature/support-runtimei
branch
from
23b0b41 to
1111d91
Compare
|
In the last commit there is another fix for a bug that I discovered. We did not always write the SMSPEC file at the end of the simulation. If there was an adaptive timestep during the last report step, we would end up with the write out after the first time step of that report step. We might therefore miss some keywords or wgnames if there were changes due to ACTIONX |
|
jenkins build this opm-simulators=6894 please |
2 participants
This is needed by some external tools.
RUNTIMEI is an integer vector of size 50 and we store the following
All other items are zero.