[LGR] Support writing NNA blocks for cross-LGR NNC connections#5060
Merged
bska merged 4 commits intoOPM:masterfrom Mar 13, 2026
Merged
[LGR] Support writing NNA blocks for cross-LGR NNC connections#5060bska merged 4 commits intoOPM:masterfrom
bska merged 4 commits intoOPM:masterfrom
Conversation
Member
Author
|
jenkins build this please |
Member
Author
|
jenkins build this please |
bska
approved these changes
Mar 13, 2026
Member
bska
left a comment
There was a problem hiding this comment.
Very good. I'll merge into master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support writing NNA blocks for cross-LGR NNC connections
Description
This PR extends the EGRID writer to support cross-LGR NNC connections using the
NNAkeywords.Previously, only the following NNC types were written:
NNC1/NNC2)NNCL/NNCG)Connections between two different LGR grids were not written to the EGRID file.
This PR adds support for those connections via:
NNCHEADANNA1NNA2Implementation
The following changes were introduced:
save_nna()to write cross-grid NNC blocks.NNCCollection::diff_grid_nnc()to detect connections between different grids.grid = 0) in the NNA stage since those are written asNNCL/NNCG.save_nnc_local_global()by removing thelocal_firstparameter and assuming the normalized ordering provided byNNCDiffGrid.New output structure:
NNCHEAD,NNC1,NNC2NNCHEAD,NNCL,NNCGNNCHEADA,NNA1,NNA2Tests
Added a new integration test:
The test:
NNCCollectioncontaining:Bug fixes
save_nnc_local_global was also simplified, ensuring consistent order of NNCL and NNCG. Tests were changed accordingly.