Skip to content

adding solvent to BlackOilFluidState#5064

Open
GitPaean wants to merge 1 commit intoOPM:masterfrom
GitPaean:adding_solvent_blackoilfluidstate
Open

adding solvent to BlackOilFluidState#5064
GitPaean wants to merge 1 commit intoOPM:masterfrom
GitPaean:adding_solvent_blackoilfluidstate

Conversation

@GitPaean
Copy link
Member

The main motivation is to support other development which requires that we can create FluidState for the wellbore.

Under certain circumstances, there might be only be Solvent in side the wellbore. With the master branch, solvent saturation is stored in blackoilsolventmodules.hh .

With the new design, some implementation might be able to be done in different ways, but this PR is mostly moving things around.

@GitPaean GitPaean added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Mar 15, 2026
@GitPaean
Copy link
Member Author

jenkins build this opm-simulators=6939 failure_report please

@GitPaean
Copy link
Member Author

The only failure is https://ci.opm-project.org/job/opm-common-PR-builder/9571/testReport/junit/(root)/default/compareECLFiles_flow_SPE5CASE1/

Comparing SEQNUM ...  done.
Comparing INTEHEAD ...  done.
Comparing LOGIHEAD ...  done.
Comparing DOUBHEAD ...  done.
Comparing IGRP ...  done.
Comparing SGRP ...  done.
Comparing XGRP ...  done.
Comparing ZGRP ...  done.
Comparing IWEL ... 

Keyword: IWEL, origin Restart, sequence 43

Value index                 = 318
(first value, second value) = (-1, 3)

Program threw an exception: [/build/test_util/EclRegressionTest.cpp:183] Non floating point values not identical 
Comparing '/build/deps/opm-tests/spe5/opm-simulation-reference/flow/SPE5CASE1' to '/build/default/build-opm-simulators/tests/results/flow+spe5/SPE5CASE1'.

Loading EGrid /build/deps/opm-tests/spe5/opm-simulation-reference/flow/SPE5CASE1.EGRID  ....  done.
Loading EGrid /build/default/build-opm-simulators/tests/results/flow+spe5/SPE5CASE1.EGRID  ....  done.
comparing grids 

Comparing egrid files 

Dimensions              ...  done.
Active cells            ...  done.
X, Y and Z coordinates  ...  done.
NNC indices             ...  done.

Loading INIT file /build/deps/opm-tests/spe5/opm-simulation-reference/flow/SPE5CASE1.INIT  .... done
Loading INIT file /build/default/build-opm-simulators/tests/results/flow+spe5/SPE5CASE1.INIT  .... done

not totally sure what it is about. Maybe @bska can give some suggestions. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant