Open
Conversation
Member
Author
|
jenkins build this opm-simulators=6939 failure_report please |
Member
Author
|
The only failure is https://ci.opm-project.org/job/opm-common-PR-builder/9571/testReport/junit/(root)/default/compareECLFiles_flow_SPE5CASE1/ not totally sure what it is about. Maybe @bska can give some suggestions. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main motivation is to support other development which requires that we can create FluidState for the wellbore.
Under certain circumstances, there might be only be Solvent in side the wellbore. With the master branch, solvent saturation is stored in blackoilsolventmodules.hh .
With the new design, some implementation might be able to be done in different ways, but this PR is mostly moving things around.