remove the usage of Schedule::filterConnections() #6806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitPaean
added
the
manual:irrelevant
Member
|
This has the same effect as #6787, except it's a little more expensive. If we do end up merging OPM/opm-common#4975, and in my opinion we should, then the final version here should be more comprehensive than the current proposal. |
Member
Author
You are right. I only search the usage of |
GitPaean
force-pushed
the
removing_filterConnections
branch
from
cf4d31d to
85af872
Compare
Member
Author
|
jenkins build this opm-common=4975 please |
bska
approved these changes
Feb 10, 2026
Member
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Very good. I'll merge into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following OPM/opm-common#4975