Earthwork tutorials: update for compatibility with new version of r.earthworks #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, still needed. My PR #90 does not correctly fix that link yet. Should I
update it to do so or would it be better merge this after?
…On Fri, Aug 8, 2025, 1:51 PM Gregory Power ***@***.***> wrote:
*gregorywaynepower* left a comment (OSGeo/grass-tutorials#90)
<#90 (comment)>
Hey @baharmon <https://github.com/baharmon> , would #91
<#91> still be necessary
after this PR?
—
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACPJKXYILEXHIJRIA6R4PQ33MTWSHAVCNFSM6AAAAACDDXLKXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNRZGAYDEMZYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Either, or. If this gets merged I can update my branch with your changes.
You may be able to get away with merging my branch into yours?
On Fri, Aug 8, 2025 at 14:58 Brendan Harmon ***@***.***>
wrote:
… *baharmon* left a comment (OSGeo/grass-tutorials#90)
<#90 (comment)>
Yes, still needed. My PR #90 does not correctly fix that link yet. Should
I
update it to do so or would it be better merge this after?
On Fri, Aug 8, 2025, 1:51 PM Gregory Power ***@***.***> wrote:
> *gregorywaynepower* left a comment (OSGeo/grass-tutorials#90)
> <
#90 (comment)>
>
> Hey @baharmon <https://github.com/baharmon> , would #91
> <#91> still be necessary
> after this PR?
>
> —
> Reply to this email directly, view it on GitHub
> <
#90 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ACPJKXYILEXHIJRIA6R4PQ33MTWSHAVCNFSM6AAAAACDDXLKXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNRZGAYDEMZYGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHM4WC5IM62E7F232W7XZF33MTXOJAVCNFSM6AAAAACDDXLKXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNRZGAYTSNJRGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
petrasovaa
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earthwork tutorials need updating due to a new release of r.earthworks pending this pull request in the addon repo. The input parameter
ratehas been replaced with different parameters for each of the new slope functions. This required updating all of the tutorials and their notebooks.