Fix misleading comment for double-submit-cookie validation #1888
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xgaurav
requested review from
jmanico,
kwwall,
mackowski and
szh
as code owners
jmanico
approved these changes
Nov 10, 2025
andrzejsydor
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You're A Rockstar
Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.
This PR corrects a misleading comment in the Cross-Site Request Forgery Prevention Cheat Sheet.
The current comment suggests the CSRF token can be read from "form field, cookie, or header".
This is incorrect for the double-submit-cookie pattern, since trusting the cookie directly breaks the intended security model.
The updated comment clarifies that the token should be read from a header or form parameter — not directly from the cookie.
This PR fixes issue #<ISSUE_NUMBER>.
AI Tool Usage Disclosure (required for all PRs)