Skip to content

fix(table): correct rendering of wrapped tables with concealed content #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ImmanuelHaffner wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

fix(table): correct rendering of wrapped tables with concealed content #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4dc37d7
fix(renderer): use visual width for table wrap check
ImmanuelHaffner Mar 18, 2026
ce3446d
fix(tostring): handle strikethrough markers in visual width calculation
ImmanuelHaffner Mar 18, 2026
ad33bd3
fix(table): add wrap continuation borders via deferred post_render
ImmanuelHaffner Mar 18, 2026
c025530
fix(table): use markview highlights for all table borders in wrapped …
ImmanuelHaffner Mar 18, 2026
ebf5fb1
fix(table): add right border on first screen row of wrapping lines
ImmanuelHaffner Mar 18, 2026
a0b9bd5
fix(table): correct top/bottom border indentation in nested tables
ImmanuelHaffner Mar 18, 2026
a407549
fix: stabilize inline virt_text ordering at shared positions in table…
ImmanuelHaffner Mar 19, 2026
7132298
fix: strip blockquote continuation prefix from table rows in parser
ImmanuelHaffner Mar 19, 2026
22fd50a
test: add markdown stress test for table rendering
ImmanuelHaffner Mar 19, 2026
aa0449e
test: add regression examples for visual rendering
ImmanuelHaffner Mar 19, 2026
0dde47d
refactor(markdown): replace screenpos with nvim_win_text_height for w…
ImmanuelHaffner Mar 20, 2026
cf766df
fix(renderer): use analytical wrap-line placement for table borders
ImmanuelHaffner Mar 20, 2026
edb0940
fix(renderer): use binary search over vcols for wrap continuation bor…
ImmanuelHaffner Mar 20, 2026
7c6421a
fix(inline): remove hl_mode combine from link extmarks to prevent gho…
ImmanuelHaffner Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lua/markview/parsers/markdown.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,8 +885,19 @@ markdown.table = function (_, _, text, range)
end

for l, line in ipairs(text) do
--- Strip block_continuation prefixes(e.g. `> `)
--- from lines after the first.
--- `get_node_text()` only applies col_start to line 1.
if l > 1 then
line = line:sub(range.col_start + 1);
end

local row_text = line;

if row_text == "" or row_text:match("^%s*$") then
goto continue;
end

if l == 1 then
header = line_processor(row_text);
elseif l == 2 then
Expand Down Expand Up @@ -917,6 +928,8 @@ markdown.table = function (_, _, text, range)
else
table.insert(rows, line_processor(row_text))
end

::continue::
end

local top_border, border_overlap = overlap(range.row_start);
Expand Down
Loading
Loading