fix(prometheus): quote external_labels values in YAML template#447
Merged
fix(prometheus): quote external_labels values in YAML template#447
Conversation
Unquoted sed-substituted values can break YAML parsing when cluster names contain special characters (#, :, etc).
Karthiksrinatha
approved these changes
Mar 12, 2026
OisinKyne
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$SERVICE_OWNER,$CLUSTER_NAME,$CLUSTER_PEERand$PROM_REMOTE_WRITE_TOKENinprometheus.yml.examplesedinrun.shcan contain YAML-special characters (#,:,[, etc.) that break config parsing$ALERT_DISCORD_IDSwas already quoted — this aligns the restTest plan
docker compose up -dwithCLUSTER_NAMEcontaining#or:characters