Skip to content

Peterson implemented three improvements on the user permissions management modal.#4217

Open
peterson337 wants to merge 3 commits intodevelopmentfrom
peterson-implement-three-improvements-user-permissions-management-modal
Open

Peterson implemented three improvements on the user permissions management modal.#4217
peterson337 wants to merge 3 commits intodevelopmentfrom
peterson-implement-three-improvements-user-permissions-management-modal

Conversation

@peterson337
Copy link
Contributor

@peterson337 peterson337 commented Oct 15, 2025

Description

This PR was opened to implement three improvements on the Manage Permissions modal.

Related PRS (if any):

None

Main changes explained:

The UserPermissionsPopUp.jsx component has been modified to fix the bug.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. Log in as an admin or owner user.
  5. go to Other Links→ Permissions Management → Manage User Permissions
  6. Click on the submit button while the input is empty. After that, a red toast should appear.
  7. Type the name of a user that doesn’t exist and click on the submit button. After that, a red toast should appear.
  8. Type the name of a valid user and click on the submit button. After that, the modal should hide and a green toast will appear.

Screenshots or videos of changes:

Before my fix:

Before.my.fix.mp4

After my fix:

After.my.fix.mp4

Note:

None

@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 13090e1
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69a615166bd94300081cf0ac
😎 Deploy Preview https://deploy-preview-4217--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link

@peterson337 peterson337 added do not review Do not review or look at code without full context and removed do not review Do not review or look at code without full context labels Oct 16, 2025
@hemanthvenkat
Copy link

Verified the PR — functionality works as expected. Red toast appears for empty and invalid user inputs, and green toast appears for valid user submission with modal closing successfully.

PR4217.mp4

@beblicarl
Copy link
Contributor

This feature works as intended and the code is great

https://www.loom.com/share/28d5aff22f1c4bfd8d14640dd212d4bb

@beblicarl beblicarl self-requested a review November 7, 2025 11:32
beblicarl
beblicarl previously approved these changes Nov 7, 2025
nathanah
nathanah previously approved these changes Feb 12, 2026
Copy link
Contributor

@nathanah nathanah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterson337 peterson337 dismissed stale reviews from nathanah and beblicarl via 13090e1 March 2, 2026 22:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants