Skip to content

Conversation

@BreathingFlesh
Copy link
Contributor

@BreathingFlesh BreathingFlesh commented Oct 23, 2025

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Org: Newsletter just show lead

Add option to just show the lead text of the news items in the newsletters.

TYPE: Feature
LINK: OGC-2343

Checklist

  • I have performed a self-review of my code
  • I have updated the PO files
  • I made changes/features for both org and town6
  • I have tested my code thoroughly by hand
  • I have added tests for my changes/features

@linear
Copy link

linear bot commented Oct 23, 2025

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.37%. Comparing base (0d9d4c8) to head (03b9505).
⚠️ Report is 5 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/newsletter/collection.py 100.00% <ø> (ø)
src/onegov/newsletter/models.py 98.95% <100.00%> (ø)
src/onegov/org/cronjobs.py 88.37% <100.00%> (+0.01%) ⬆️
src/onegov/org/forms/newsletter.py 87.50% <100.00%> (ø)
src/onegov/org/forms/settings.py 70.99% <100.00%> (+0.03%) ⬆️
src/onegov/org/models/extensions.py 90.28% <ø> (-0.14%) ⬇️
src/onegov/org/models/organisation.py 95.29% <100.00%> (+0.01%) ⬆️
src/onegov/org/models/page.py 88.98% <100.00%> (ø)

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d9d4c8...03b9505. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +735 to +744
context.add_column_with_defaults(
'newsletters',
Column(
'show_only_previews',
Boolean,
nullable=False,
default=False
),
default=False
)
Copy link
Member

@Daverball Daverball Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be populated using content['show_news_as_tiles']? Otherwise people will have to manually adjust the setting. Unless the setting is so new that only Wil was using it anyways.

You should also remove the key from the content afterwards, so it doesn't take up any unnecessary space.

@BreathingFlesh BreathingFlesh merged commit ffba57f into master Nov 5, 2025
16 checks passed
@BreathingFlesh BreathingFlesh deleted the ogc-2343-news-text branch November 5, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants