-
Notifications
You must be signed in to change notification settings - Fork 2
Ogc 2343 news text #2160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ogc 2343 news text #2160
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| context.add_column_with_defaults( | ||
| 'newsletters', | ||
| Column( | ||
| 'show_only_previews', | ||
| Boolean, | ||
| nullable=False, | ||
| default=False | ||
| ), | ||
| default=False | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be populated using content['show_news_as_tiles']? Otherwise people will have to manually adjust the setting. Unless the setting is so new that only Wil was using it anyways.
You should also remove the key from the content afterwards, so it doesn't take up any unnecessary space.
Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.
Commit message
Org: Newsletter just show lead
Add option to just show the lead text of the news items in the newsletters.
TYPE: Feature
LINK: OGC-2343
Checklist