Skip to content

Conversation

@fadi-george
Copy link
Collaborator

@fadi-george fadi-george commented Oct 28, 2025

Description

One Line Summary

  • add semantic pr title checker

Details

  • adds semantic pr title linter workfow

Motivation

  • want to use semantic pr titles to generate release notes

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@fadi-george fadi-george force-pushed the fg/semantic-release-pr branch 2 times, most recently from 10f4dc1 to 63a4492 Compare October 28, 2025 23:25
# supported CodeQL languages.
#
name: "CodeQL"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a line to describe what this workflow does

description: ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres no description field, theres already a comment above

@@ -0,0 +1,27 @@
name: Lint PR

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a description here.

So this Action gets called automatically? Where is the output of this redirected to?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would need to be merged to main for it to be recognized, then i can make it a required check

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment

@fadi-george fadi-george force-pushed the fg/semantic-release-pr branch from d7f4829 to bbe2a0c Compare October 29, 2025 18:24
@fadi-george fadi-george merged commit d26d108 into main Oct 29, 2025
4 checks passed
@fadi-george fadi-george deleted the fg/semantic-release-pr branch October 29, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants