Save consent granted to shared user defaults

* Previously this was saved only to the standard user defaults so it could not be read by the NSE, which blocked confirmed deliveries from being sent, even after consent has been granted.
* Additionally, migrate this from the standard user defaults to the shared user defaults.

Author: nan-li

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSPrivacyConsentController.h

@@ -27,6 +27,7 @@ THE SOFTWARE.
 
 
 @interface OSPrivacyConsentController : NSObject
++ (void)migrate;
 + (BOOL)requiresUserPrivacyConsent;
 + (void)consentGranted:(BOOL)granted;
 + (BOOL)shouldLogMissingPrivacyConsentErrorWithMethodName:(NSString *)methodName;

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSPrivacyConsentController.m

@@ -35,6 +35,29 @@ of this software and associated documentation files (the "Software"), to deal
 
 @implementation OSPrivacyConsentController
 
++ (void)migrate {
+    [self migrateConsentGranted];
+}
+
+/// `GDPR_CONSENT_GRANTED` had previously been saved to the standard user defaults.
+/// However, this value is also read from the NSE (for example, to send confirmed deliveries).
+/// Migrate this value to the shared user defaults, if it exists.
++ (void)migrateConsentGranted {
+    long consentGrantedCacheFixVersion = 50210;
+    long sdkVersion = [OneSignalUserDefaults.initShared getSavedIntegerForKey:OSUD_CACHED_SDK_VERSION_FOR_CORE defaultValue:0];
+
+    if (sdkVersion >= consentGrantedCacheFixVersion) {
+        return;
+    }
+    
+    if ([OneSignalUserDefaults.initStandard keyExists:GDPR_CONSENT_GRANTED]) {
+        [OneSignalLog onesignalLog:ONE_S_LL_DEBUG message:[NSString stringWithFormat:@"OSPrivacyConsentController migrating consent granted from version: %ld", sdkVersion]];
+        // The default value should never be used, however the getSavedBoolForKey method requires it
+        BOOL granted = [OneSignalUserDefaults.initStandard getSavedBoolForKey:GDPR_CONSENT_GRANTED defaultValue:false];
+        [OneSignalUserDefaults.initShared saveBoolForKey:GDPR_CONSENT_GRANTED withValue:granted];
+    }
+}
+
 + (void)setRequiresPrivacyConsent:(BOOL)required {
     OSRemoteParamController *remoteParamController = [OSRemoteParamController sharedController];
 
@@ -56,13 +79,13 @@ + (BOOL)requiresUserPrivacyConsent {
     // if required and consent has not been previously granted, return false
     BOOL requiresConsent = [[[NSBundle mainBundle] objectForInfoDictionaryKey:ONESIGNAL_REQUIRE_PRIVACY_CONSENT] boolValue] ?: false;
     if (requiresConsent || shouldRequireUserConsent)
-        return ![OneSignalUserDefaults.initStandard getSavedBoolForKey:GDPR_CONSENT_GRANTED defaultValue:false];
+        return ![OneSignalUserDefaults.initShared getSavedBoolForKey:GDPR_CONSENT_GRANTED defaultValue:false];
 
     return false;
 }
 
 + (void)consentGranted:(BOOL)granted {
-    [OneSignalUserDefaults.initStandard saveBoolForKey:GDPR_CONSENT_GRANTED withValue:granted];
+    [OneSignalUserDefaults.initShared saveBoolForKey:GDPR_CONSENT_GRANTED withValue:granted];
 }
 
 + (BOOL)shouldLogMissingPrivacyConsentErrorWithMethodName:(NSString *)methodName {

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalCore.m

@@ -32,6 +32,7 @@ @implementation OneSignalCoreImpl
 
 + (void)migrate {
     [self migrateCachedSdkVersion];
+    [OSPrivacyConsentController migrate];
     [self saveCurrentSDKVersion];
 }