Skip to content

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Apr 18, 2025

One Line Summary

Add 2 short sound files to dev app.

Details

Motivation

  • This allows testing custom sounds in notifications

Scope

Testing

Manual testing

Tested sending notification from dashboard using both sounds, and works.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

* This allows testing custom sounds in notifications
* The two sounds are "click.wav" and "bark.wav"
@nan-li nan-li requested review from jinliu9508 and jkasten2 April 18, 2025 19:37
@nan-li nan-li merged commit 456be5c into main Apr 29, 2025
3 of 4 checks passed
@nan-li nan-li deleted the dev_app/add_sound_file branch April 29, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants