fix: live activities uncaches correctly #1589
Open
+37
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode warns: *** -[NSKeyedUnarchiver decodeObjectForKey:]: value for key (requestSuccessful) is not an object. This will become an error in the future.
nan-li
changed the title
* The optional cast directly to a protocol always failed, and this intermediate step of casting to Any/AnyObject was necessary.
nan-li
force-pushed
the
fix/live_activities_caching
branch
from
f674d59 to
b2d84f0
Compare
jkasten2
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Correctly uncache live activities requests, by using an intermediary cast first as a bridge.
Details
Motivation
The SDK was never uncaching live activities requests, as using a safe cast directly to a protocol fails. It might be an issue with bridging from Objective-C or the compiler could not be definitely sure and errs on the side of caution. However it seems casting it to
[String: AnyObject]before casting to[String: OSLiveActivityRequest]works. A force-cast also works perhaps by bypassing the first safety layer, but force-casts are dangerous. Fortunately, this alternative seems to work correctly.Scope
Live activities requests will now be uncached, reduce extraneous requests.
Testing
Unit testing
Added
testRequestsUncacheCorrectlythat caches and uncaches each live activity request type.Manual testing
Testing on physical iPhone 13, iOS 18.6.2
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is