-
Notifications
You must be signed in to change notification settings - Fork 0
CI: actions/checkout v3 to v5 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughUpdated the GitHub Actions workflow for production deployment by bumping actions/checkout from v3 to v5 in .github/workflows/deploy-oss.yml. No other steps or logic were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/deploy-oss.yml (1)
46-53
: Use key‑based SSH auth and pin host keys; avoid “password” fields for keys.You’re passing a secret named SSH_KEY into
password
. Prefer private key inputs and host key pinning for both actions. Also separate SSH auth from sudo creds. (github.com)- with: - local: ./build - remote: /tmp/${{ env.BOX_NAME }} - host: ${{ secrets.HOST }} - username: ${{ secrets.USER }} - password: ${{ secrets.SSH_KEY }} + with: + local: ./build + remote: /tmp/${{ env.BOX_NAME }} + host: ${{ secrets.HOST }} + username: ${{ secrets.USER }} + privateKey: ${{ secrets.DEPLOY_SSH_PRIVATE_KEY }} + passphrase: ${{ secrets.DEPLOY_SSH_PASSPHRASE }}- with: - host: ${{ secrets.HOST }} - username: ${{ secrets.USER }} - password: ${{ secrets.SSH_KEY }} + with: + host: ${{ secrets.HOST }} + username: ${{ secrets.USER }} + key: ${{ secrets.DEPLOY_SSH_PRIVATE_KEY }} + passphrase: ${{ secrets.DEPLOY_SSH_PASSPHRASE }} + fingerprint: ${{ secrets.HOST_SSH_FINGERPRINT }}Optional: keep a separate secret for
sudo
(don’t reuse SSH creds) and consider avoiding sudo by granting the deploy user minimal required privileges.Also applies to: 55-60
🧹 Nitpick comments (2)
.github/workflows/deploy-oss.yml (2)
25-26
: Update Docker setup actions to v3 (current recommended).Both actions have v3 as the current line; upgrade for maintained features and fixes.
- - uses: docker/setup-qemu-action@v2 - - uses: docker/setup-buildx-action@v2 + - uses: docker/setup-qemu-action@v3 + - uses: docker/setup-buildx-action@v3Refs show v3 in examples/readme. (github.com)
29-29
: Consider bumping docker/build-push-action to v6.v6 is the current stable and aligns with newer cache/back-end requirements and docs. This future‑proofs builds (e.g., GA cache API v2 era). (docs.docker.com)
- uses: docker/build-push-action@v3 + uses: docker/build-push-action@v6
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/deploy-oss.yml
(1 hunks)
🔇 Additional comments (1)
.github/workflows/deploy-oss.yml (1)
23-23
: Good bump to actions/checkout v5; verify runner compatibility if self‑hosted.V5 is live and uses the Node 24 runtime; it requires Actions Runner ≥ v2.327.1. On GitHub‑hosted runners you’re fine; for any self‑hosted, confirm runner version. (github.com)
Summary by CodeRabbit