Expanded beer categories and styles #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used the 2015 BJCP (Beer Judge Certification Program) Style Guidelines. It has 34 overall categories with different specific styles under each one. Link to the guidelines: https://www.bjcp.org/docs/2015_Guidelines_Beer.pdf
removed a final ',' that made the file not pass the checks
shiffman
reviewed
Sep 25, 2018
Member
shiffman
left a comment
shiffman
left a comment
There was a problem hiding this comment.
Great job! I wonder if the maintainers of corpora would prefer to have both a simple array of beer categories and this more complex and detailed dataset? I would probably do what you did and expand the original file, but just curious to ask the question!
| @@ -1,16 +1,630 @@ | |||
| { | |||
| "description": "A list of beer categories.", | |||
| "description": "A list of beer categories and corresponding styles, according to the BJCP 2015 Style Guidelines", | |||
Member
There was a problem hiding this comment.
I would include a "source" property as well with a link to the PDF you referenced!
Add source to the json object linking to the BJCP 2015 Style Guidelines pdf file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the 2015 BJCP (Beer Judge Certification Program) Style Guidelines. It has 34 overall categories with different specific styles under each one.
Link to the guidelines: https://www.bjcp.org/docs/2015_Guidelines_Beer.pdf