Make OBP-Keycloak-Provider fully configurable via ENV variables #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolved merge conflicts in .gitignore - Combined environment variable support with upstream CI/CD improvements - Kept persistence.xml with environment variable placeholders - Added comprehensive environment configuration tooling
constantine2nd
changed the title
- persistence.xml should be generated from persistence.xml-example - Contains environment-specific configuration that shouldn't be in VCS - Already listed in .gitignore but was previously tracked
karmaking
requested changes
Aug 18, 2025
There was a problem hiding this comment.
While this approach technically works, it does not support k8s deployments or deployments from e.g. a Dockerhub-hosted image.
The run-with-env.sh builds a customised image injecting the env vars to maven, but we rather need to be able to configure the keycloak provider via env vars at run time, not at build time.
So the java artifact needs to be able to read the env vars when it boots.
In general, custom shell scripts to build and run a container don't work with Kubernetes. And we want to be able to host generic and ready-to-use docker images on Dockerhub in our standard deployment pipelines.
cloud-native deployments with runtime configuration
Keycloak Admin Console
persistant fast integer `id`
code and docmentation
been configured as READ-ONLY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.