Skip to content

Merge dev branch into dev-tc branch#3191

Merged
deslaughter merged 327 commits intoOpenFAST:dev-tcfrom
deslaughter:dev_to_dev-tc
Feb 6, 2026
Merged

Merge dev branch into dev-tc branch#3191
deslaughter merged 327 commits intoOpenFAST:dev-tcfrom
deslaughter:dev_to_dev-tc

Conversation

@deslaughter
Copy link
Collaborator

@deslaughter deslaughter commented Feb 5, 2026

This PR is ready to merge.

Feature or improvement description

This PR merges the dev branch into the dev-tc branch in preparation of making dev-tc the new dev branch, which will then become OpenFAST 5.0.

Test results, if applicable

  • r-test branch merging required

andrew-platt and others added 30 commits September 10, 2025 05:43
- remove extra `IMPLICIT NONE` statements
- change name SeaSt_GetWaveFieldPointer_C to SeaSt_C_GetWaveFieldPointer (matches convention elsewehre)
- SeaSt_C_GetFluidVelAccDens
- SeaSt_C_GetSurfElev
…eVelAcc

- add acceleration output (similar to `dev-tc` usage)
- I don't see anything that directly uses this.
- SeaSt_C_GetWaveFieldPointer - convert to subroutine, add error handling, add DebugLevel
- SeaSt_C_SetWaveFieldPointer - new routine
- python lib: revisions to support above, and also to support a new regression test (in progress)
making sure to close file handle in ofio turbsim reader
the flag for node in or out of water is sufficient.  The density is constant throughout the water column.
- removed outdated SeaState.py example since it is no longer compatible
- remove WrVTK_inDxy from the interface
- fix some broken error handling
- clears out memory that is allocated within the c-bindings library that the _End routine doesn't catch
these are all subroutine calls, so no returns
GH: update the PR template: include AI section, r-test update
There was no reason to keep 8 decimal places
Updates to SeaState c-bindings library interface
* Currently only supports 3D and 4D interpolation. Can add 2D interpolation in the future if needed.
* Supports interpolation of scalar data, 3-by-1 vector data, and 6-by-1 vector data.
* Will use C1 continuous cubic interpolation if possible. Toward grid boundary, quadratic interpolation is used. Linear interpolation is used if only two grid points are present.
* If one of the grid dimensions has only 1 grid point, this dimension is effectively ignored.
* Each dimension can be indicated as either periodic or not.
* Periodic dimensions will always use cubic interpolation because the grid is effectively infinite in this direction.
* For non-periodic dimensions, a query point will be snapped back to the grid boundary if out of bound. A warning will be given at the first occurrence.
* Note that for periodic dimensions, the subroutines assume the first and last grid points are NOT duplicates of each other.
@deslaughter deslaughter added this to the v5.0.0 milestone Feb 5, 2026
@deslaughter deslaughter self-assigned this Feb 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@deslaughter deslaughter marked this pull request as ready for review February 6, 2026 01:22
@deslaughter deslaughter requested a review from Copilot February 6, 2026 01:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 134 out of 152 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@andrew-platt andrew-platt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen all these changes before. I didn't review it in detail, but they are ready for merging.

@deslaughter deslaughter merged commit 9a5855e into OpenFAST:dev-tc Feb 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants