Skip to content

Conversation

emersion
Copy link
Member

@emersion emersion commented Sep 9, 2025

ESLint v9 requires flat configs, it no longer supports the legacy
config file format. Migrate our configuration file to prepare for
the bump.

--ext has been removed from the package.json script because ESLint
rejects that CLI option when used with flat configs: file extensions
are now specified in the config file directly.

Depends on #13105
Part of #12395
See also #13134

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Sep 9, 2025
@emersion emersion moved this to Awaiting merge in Board PI 16 Sep 9, 2025
@emersion emersion self-assigned this Sep 9, 2025
@emersion emersion force-pushed the emr/front-flat-eslint-cfg branch 2 times, most recently from e1af9d6 to 249934e Compare September 12, 2025 10:15
@emersion emersion marked this pull request as ready for review September 12, 2025 10:15
@emersion emersion requested a review from a team as a code owner September 12, 2025 10:15
@emersion emersion force-pushed the emr/front-flat-eslint-cfg branch from 249934e to bc49c63 Compare September 12, 2025 11:01
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks for handling this painful migration !

Just 2 minor questions

@emersion emersion force-pushed the emr/front-flat-eslint-cfg branch from bc49c63 to 02fc5ef Compare September 12, 2025 15:02
@SharglutDev
Copy link
Contributor

Something went wrong in the rebase ? The commit name /description doesn't seem to be the good one :)

@emersion emersion force-pushed the emr/front-flat-eslint-cfg branch 2 times, most recently from 888d796 to 8eccd79 Compare September 12, 2025 15:22
@emersion
Copy link
Member Author

Something went wrong in the rebase ? The commit name /description doesn't seem to be the good one :)

Oops, fixed now!

Copy link
Contributor

@Synar Synar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emersion emersion force-pushed the emr/front-flat-eslint-cfg branch from 8eccd79 to 897c611 Compare September 19, 2025 08:23
@emersion emersion enabled auto-merge September 19, 2025 08:28
@emersion emersion added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@emersion emersion added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@Akctarus Akctarus removed this from Board PI 16 Sep 22, 2025
@Akctarus Akctarus moved this to Awaiting merge in Board PI 17 Sep 22, 2025
@emersion
Copy link
Member Author

Hmm, unfortunately @rollup/eslint doesn't support flat configs. See rollup/plugins#1607

@emersion
Copy link
Member Author

Ref rollup/plugins#1898

This is required to get support for flat config files:
rollup/plugins#1898

Signed-off-by: Simon Ser <[email protected]>
ESLint v9 requires flat configs, it no longer supports the legacy
config file format. Migrate our configuration file to prepare for
the bump.

--ext has been removed from the package.json script because ESLint
rejects that CLI option when used with flat configs: file extensions
are now specified in the config file directly.

Signed-off-by: Simon Ser <[email protected]>
@emersion
Copy link
Member Author

emersion commented Oct 4, 2025

The rollup plugin PR linked above has been merged, so this can progress now!

@emersion emersion added this pull request to the merge queue Oct 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2025
@emersion emersion added this pull request to the merge queue Oct 4, 2025
Merged via the queue into dev with commit e0a21ad Oct 4, 2025
29 checks passed
@emersion emersion deleted the emr/front-flat-eslint-cfg branch October 4, 2025 19:16
@github-project-automation github-project-automation bot moved this from Awaiting merge to Done in Board PI 17 Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:front Work on Standard OSRD Interface modules

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants