-
Notifications
You must be signed in to change notification settings - Fork 60
front: migrate to ESLint flat config #13135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e1af9d6
to
249934e
Compare
249934e
to
bc49c63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks for handling this painful migration !
Just 2 minor questions
bc49c63
to
02fc5ef
Compare
Something went wrong in the rebase ? The commit name /description doesn't seem to be the good one :) |
888d796
to
8eccd79
Compare
Oops, fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
8eccd79
to
897c611
Compare
Hmm, unfortunately |
This is required to get support for flat config files: rollup/plugins#1898 Signed-off-by: Simon Ser <[email protected]>
ESLint v9 requires flat configs, it no longer supports the legacy config file format. Migrate our configuration file to prepare for the bump. --ext has been removed from the package.json script because ESLint rejects that CLI option when used with flat configs: file extensions are now specified in the config file directly. Signed-off-by: Simon Ser <[email protected]>
897c611
to
8cd1875
Compare
The rollup plugin PR linked above has been merged, so this can progress now! |
ESLint v9 requires flat configs, it no longer supports the legacy
config file format. Migrate our configuration file to prepare for
the bump.
--ext has been removed from the package.json script because ESLint
rejects that CLI option when used with flat configs: file extensions
are now specified in the config file directly.
Depends on #13105
Part of #12395
See also #13134