front: fix track_name on timetable for imported train #13771
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Oct 22, 2025
|
CC'ing @Synar since she's worked on tracks in the output table. |
aschantraine
force-pushed
the
ace/missing-track-name-on-timetable
branch
from
aa5044e to
99ccfeb
Compare
Synar
reviewed
Oct 28, 2025
SharglutDev
reviewed
Oct 30, 2025
aschantraine
force-pushed
the
ace/missing-track-name-on-timetable
branch
2 times, most recently
from
fe84184 to
79f0ede
Compare
Signed-off-by: aschantraine <[email protected]>
aschantraine
force-pushed
the
ace/missing-track-name-on-timetable
branch
from
79f0ede to
bee6d0e
Compare
Signed-off-by: aschantraine <[email protected]>
emersion
reviewed
Oct 30, 2025
| return ( | ||
| trackSections[trackReference.track_id]?.extensions?.sncf?.track_name ?? trackReference.track_id | ||
| ); | ||
| return trackSections[trackReference.track_id]?.extensions?.sncf?.track_name ?? '?'; |
There was a problem hiding this comment.
Nit: in general I prefer to handle formatting concerns (in other words, how unknown/missing values should be presented to the user) in the JSX template rather than storing it in the trackName field.
Hm, that said, we already use undefined to mean "unspecified", so we'd need another value to mean "specified but not found". null wouldn't be very explicit and would be easy to confuse with undefined…
There was a problem hiding this comment.
So, what do you suggest ? Since it’s going to change soon, maybe we should keep track_reference.id after all ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
getTrackReferenceLabelfunction to accepttrackSectionsand use the SNCF extension'strack_nameinstead of the track ID when available, falling back to "?" otherwise.