WIP: Release of 0.5.0 libopenshot (for OpenShot 3.4) #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s fine to link against the previous library.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1016 +/- ##
===========================================
+ Coverage 57.31% 58.81% +1.50%
===========================================
Files 198 204 +6
Lines 18166 19775 +1609
===========================================
+ Hits 10412 11631 +1219
- Misses 7754 8144 +390 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ects offscreen and back onscreen without getting lost, and improved unit tests.
…cked Object IDs they return - to allow for multiple effects on the same clip, and to not accidentally clobber trackedObject IDs (i.e. "0" as the default tracked object ID)
…T build server doesn't have this)
…uickly makes tracked object go offscreen (go pro mp4 from raffi)
…lues - due to ID mismatches)
…he box values - due to ID mismatches)
…stable and less jitter / ID jumping between detections.
…from loading correctly.
…he ->number property of a null frame.
…sh from unknown codecs.
…lusive on min, and exclusive on max (trying to prevent rounding errors on last frame)
…te input / output FOVs for fisheye processing.
… fish eyes for input and output). Fixing lots of issues with virtual camera controls (so controls don't flip axis randomly)
- make Add/Remove Effect methods thread safe - Fix RemoveClip memory leak - Improve performance of sorting clips by position and layer, cache some common accessors, and speed up "clip intersection" logic - Don't resize audio container in loop - do it once - Large refactor of looping through clips and finding top clip - Protect ClearAllCache from empty Readers, prevent crash - Expanded unit tests to include RemoveEffect, and test many of the changes in the commit.
- Replacing alpha with QPainter SetOpactity (much faster) - Fixing get_file_extension to not crash with filepaths that do no contain a "." - Removing render hints from apply_background (since no transform or text rendering), making compositing (faster in certain cases) - Optionally adding SmoothPixmapTransform based on a valid transform (faster in certain cases) - Skip Opacity for fully opaque clips - New Clip unit tests to validate new functionality
…rtain cases, and added new wave effect unit test
…mparisons with different versions of OpenShot. Initial results: FFmpegWriter,7800 FrameMapper,3508 Clip,4958 Timeline,30817 Timeline (with transforms),53951 Effect_Mask,9283 Effect_Brightness,12486 Effect_Crop,5153 Effect_Saturation,15545 Overall,147136
-Normal -Darken -Multiply -Color Burn -Lighten -Screen -Color Dodge -Add -Overlay -Soft Light -Hard Light -Difference -Exclusion
…ble to libopenshot.
…accuracy of GIF files, plus GIF with time curves.
…ed_frame_count, and make isReady() return correctly. The result of this bug was audio starting playback sooner than video - and some general jank around video caching.
…for time-curved clips that have a modified duration/video_length (i.e. repeated clips, slowled down clips, etc...). Adding a new ReaderBase.h VideoLength() that can be overridden in Clip.cpp when time curves are involved.
…re actually reversed over the length of the clip without skipping or missing a single one.
…n 0.0 early - which was breaking reversed time curves (zero'ing out the first frame or two)
…), so we can safely flip audio buffer direction when needed (i.e. time curves, reversed time). Also adding a new SetDirectionHint function to FrameMapper class - so our Clip class can inform the FrameMapper of its direction at any given moment. Also, clear resampler when changing directions inside a Time curve (since the audio buffer will be flipped - the resampler internal cache must be cleared).
…), so we can safely flip audio buffer direction when needed (i.e. time curves, reversed time). Also adding a new SetDirectionHint function to FrameMapper class - so our Clip class can inform the FrameMapper of its direction at any given moment. Also, clear resampler when changing directions inside a Time curve (since the audio buffer will be flipped - the resampler internal cache must be cleared).
…me's getting modified)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping version to 0.5.0, SO 28, this is a major new release of libopenshot. Related to OpenShot/libopenshot-audio#166