Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 95.40% 95.53% +0.13%
==========================================
Files 23 25 +2
Lines 1153 1187 +34
==========================================
+ Hits 1100 1134 +34
Misses 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bumps the github-actions group with 1 update: [prefix-dev/setup-pixi](https://github.com/prefix-dev/setup-pixi). Updates `prefix-dev/setup-pixi` from 0.9.3 to 0.9.4 - [Release notes](https://github.com/prefix-dev/setup-pixi/releases) - [Commits](prefix-dev/setup-pixi@v0.9.3...v0.9.4) --- updated-dependencies: - dependency-name: prefix-dev/setup-pixi dependency-version: 0.9.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hans-Martin von Gaudecker <hmgaudecker@gmail.com>
…me pretty useless once we'll only support Python 3.14+
…uence-instead-of-list-only
…boilerplate-update
timmens
left a comment
There was a problem hiding this comment.
Great! Looks much more readable without the TYPE_CHECKING block.
The PR title says "Improved pre-commit hooks", but I can't see any changes to the pre-commit hooks. Am I missing something?
Apologies, I messed staggered PRs up yet again and this ended up in #71... |
timmens
left a comment
There was a problem hiding this comment.
Ah, perfect! Then this looks great to me! 🙂
Remove
if TYPE_CHECKING:blocks. They are just a distraction and will become pretty useless once we'll only support Python 3.14+