Rename / remove dense and sparse variables and refactor#103
Merged
Conversation
hmgaudecker
reviewed
Feb 13, 2025
Member
hmgaudecker
left a comment
There was a problem hiding this comment.
Very neat!
I think type annotations throughout would really help. Especially getting rid of None instances where empty containers will just do the trick and allow simplifying the code. No need to include here, but probably a good one to tackle soon.
Member
Author
|
As discussed, we will further split the code-base into parts that are relevant only for simulation or solution. For this we will also split |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_determine_dense_discrete_choice_axesFuture PRs:
discrete_problem._determine_dense_discrete_choice_axesandsimulate.determine_discrete_dense_choice_axes: They look similar, and do similar things, but not exactly -> Combine these with an argument likepurpose: Literal["solution", "simulation"].